Add permissions that were missed on the first pass #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
============================================
+ Coverage 79.35% 81.35% +2.00%
- Complexity 1262 1638 +376
============================================
Files 109 118 +9
Lines 5434 6866 +1432
============================================
+ Hits 4312 5586 +1274
- Misses 1122 1280 +158 Flags with carried forward coverage won't be shown. Click here to find out more. see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
trask
reviewed
Jul 18, 2025
Comment on lines
+18
to
+19
| permissions: | ||
| contents: write # required for pushing changes |
There was a problem hiding this comment.
I'm not sure if this is needed or not, can you run this workflow to see if it's passing already (and then can close this PR)
bobstrecansky
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See open-telemetry/sig-security#148 for details.
cc @trask